Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow evicting wanted deleted layers #6931

Merged
merged 9 commits into from
Feb 27, 2024
Merged

fix: allow evicting wanted deleted layers #6931

merged 9 commits into from
Feb 27, 2024

Conversation

koivunej
Copy link
Contributor

@koivunej koivunej commented Feb 27, 2024 •
edited
Loading

Not allowing evicting wanted deleted layers is something I've forgotten to implement on #5645. This PR makes it possible to evict such layers, which should reduce the amount of hanging evictions.

Fixes: #6928

@koivunej koivunej mentioned this pull request Feb 27, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2024 •
edited
Loading

2424 tests run: 2303 passed, 0 failed, 121 skipped (full report)

Code coverage* (full report)

  • functions: 28.5% (6843 of 23994 functions)
  • lines: 47.1% (41860 of 88933 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
e95fc3b at 2024-02-27T19:50:44.429Z :recycle:

@koivunej koivunej changed the title fix: one instance of "leaked" started evictions count fix: allow evicting wanted deleted layers Feb 27, 2024
@koivunej koivunej marked this pull request as ready for review February 27, 2024 17:52
@koivunej koivunej requested a review from a team as a code owner February 27, 2024 17:52
problame
problame approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@problame problame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@koivunej koivunej merged commit 1b1320a into main Feb 27, 2024
50 checks passed
@koivunej koivunej deleted the joonas/hanging_evictions branch February 27, 2024 22:02
koivunej added a commit that referenced this pull request Feb 27, 2024
@koivunej @problame
fix: allow evicting wanted deleted layers (#6931)
4b376a2 
Not allowing evicting wanted deleted layers is something I've forgotten
to implement on #5645. This PR makes it possible to evict such layers,
which should reduce the amount of hanging evictions.

Fixes: #6928

Co-authored-by: Christian Schwarz <christian@neon.tech>
@koivunej koivunej mentioned this pull request Mar 14, 2024
Merged
koivunej added a commit that referenced this pull request Mar 14, 2024
@koivunej
doc(README): note cargo-nextest usage (#7122)
58ef78c 
We have been using #5681 for quite some time, and at least since #6931
the tests have assumed `cargo-nextest` to work around our use of global
statics. Unlike the `cargo test`, the `cargo nextest run` runs each test
as a separate process that can be timeouted.

Add a mention of using `cargo-nextest` in the top-level README.md.
Sub-crates can still declare they support `cargo test`, like
`compute_tools/README.md` does.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@problame problame problame approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

layer: unimplemented support for evicting wanted deleted layers
2 participants
@koivunej @problame