New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix max lsn bug #7007
Merged
Merged
Fix max lsn bug #7007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladLazar
reviewed
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - Thanks for the contribution! Looks correct to me.
Please remove the stray commented out lines mentioned in the comments.
github-actions
bot
removed
the
approved-for-ci-run
Changes are safe to trigger CI for the PR
label
Mar 5, 2024
Closed
2496 tests run: 2373 passed, 0 failed, 123 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
6d2899c at 2024-03-12T10:41:53.361Z :recycle: |
github-actions
bot
removed
the
approved-for-ci-run
Changes are safe to trigger CI for the PR
label
Mar 5, 2024
VladLazar
reviewed
Mar 7, 2024
github-actions
bot
removed
the
approved-for-ci-run
Changes are safe to trigger CI for the PR
label
Mar 7, 2024
VladLazar
approved these changes
Mar 11, 2024
VladLazar
added
the
approved-for-ci-run
Changes are safe to trigger CI for the PR
label
Mar 11, 2024
github-actions
bot
removed
the
approved-for-ci-run
Changes are safe to trigger CI for the PR
label
Mar 11, 2024
VladLazar
added
the
approved-for-ci-run
Changes are safe to trigger CI for the PR
label
Mar 12, 2024
github-actions
bot
removed
the
approved-for-ci-run
Changes are safe to trigger CI for the PR
label
Mar 12, 2024
@jbajic - just merged this. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The problem it fixes is when
request_lsn
isu64::MAX-1
thecont_lsn
becomesu64::MAX
which is the same asprev_lsn
which stops the loop.Closes #6812
Checklist before requesting a review
Checklist before merging