Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix max lsn bug #7007

Merged
merged 4 commits into from Mar 12, 2024
Merged

Fix max lsn bug #7007

merged 4 commits into from Mar 12, 2024

Conversation

jbajic
Copy link
Contributor

@jbajic jbajic commented Mar 4, 2024

Summary of changes

The problem it fixes is when request_lsn is u64::MAX-1 the cont_lsn becomes u64::MAX which is the same as prev_lsn which stops the loop.

Closes #6812

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jbajic jbajic requested a review from a team as a code owner March 4, 2024 15:39
@jbajic jbajic requested a review from VladLazar March 4, 2024 15:39
Copy link
Contributor

@VladLazar VladLazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - Thanks for the contribution! Looks correct to me.
Please remove the stray commented out lines mentioned in the comments.

pageserver/src/tenant/timeline.rs Outdated Show resolved Hide resolved
pageserver/src/tenant.rs Outdated Show resolved Hide resolved
@VladLazar VladLazar added the approved-for-ci-run Changes are safe to trigger CI for the PR label Mar 5, 2024
@github-actions github-actions bot removed the approved-for-ci-run Changes are safe to trigger CI for the PR label Mar 5, 2024
@vipvap vipvap mentioned this pull request Mar 5, 2024
Copy link

github-actions bot commented Mar 5, 2024

2496 tests run: 2373 passed, 0 failed, 123 skipped (full report)


Flaky tests (1)

Postgres 15

  • test_lazy_attach_activation[delete]: debug

Code coverage* (full report)

  • functions: 28.8% (7035 of 24445 functions)
  • lines: 47.6% (43472 of 91383 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
6d2899c at 2024-03-12T10:41:53.361Z :recycle:

@jbajic jbajic requested a review from VladLazar March 5, 2024 12:54
@VladLazar VladLazar added the approved-for-ci-run Changes are safe to trigger CI for the PR label Mar 5, 2024
@github-actions github-actions bot removed the approved-for-ci-run Changes are safe to trigger CI for the PR label Mar 5, 2024
pageserver/src/tenant.rs Outdated Show resolved Hide resolved
@koivunej koivunej added the approved-for-ci-run Changes are safe to trigger CI for the PR label Mar 7, 2024
@github-actions github-actions bot removed the approved-for-ci-run Changes are safe to trigger CI for the PR label Mar 7, 2024
@jbajic jbajic requested a review from VladLazar March 7, 2024 20:39
@VladLazar VladLazar added the approved-for-ci-run Changes are safe to trigger CI for the PR label Mar 11, 2024
@github-actions github-actions bot removed the approved-for-ci-run Changes are safe to trigger CI for the PR label Mar 11, 2024
@VladLazar VladLazar added the approved-for-ci-run Changes are safe to trigger CI for the PR label Mar 12, 2024
@github-actions github-actions bot removed the approved-for-ci-run Changes are safe to trigger CI for the PR label Mar 12, 2024
@VladLazar VladLazar merged commit bac06ea into neondatabase:main Mar 12, 2024
91 of 93 checks passed
@VladLazar
Copy link
Contributor

@jbajic - just merged this. Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeline::get bug on reads at max lsn (Lsn::MAX - 1)
3 participants