Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: add new dimension to exclude cplane latency #7011

Merged
merged 5 commits into from Mar 13, 2024

Conversation

khanova
Copy link
Contributor

@khanova khanova commented Mar 4, 2024

Problem

Currently cplane communication is a part of the latency monitoring. It doesn't allow to setup the proper alerting based on proxy latency.

Summary of changes

Added dimension to exclude cplane latency.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented Mar 4, 2024

2490 tests run: 2367 passed, 0 failed, 123 skipped (full report)


Code coverage* (full report)

  • functions: 28.8% (6982 of 24253 functions)
  • lines: 47.4% (42897 of 90559 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
9c5493b at 2024-03-06T10:48:52.156Z :recycle:

@khanova
Copy link
Contributor Author

khanova commented Mar 4, 2024

Check with preview, seems to work.

@khanova khanova marked this pull request as ready for review March 4, 2024 20:56
@khanova khanova requested a review from a team as a code owner March 4, 2024 20:56
@khanova khanova merged commit b0aff04 into main Mar 13, 2024
53 checks passed
@khanova khanova deleted the proxy-add-new-dimension-to-exclude-cplane-latency branch March 13, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants