Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: clippy disallow futures::pin_mut macro #7016

Merged
merged 5 commits into from Mar 5, 2024

Conversation

koivunej
Copy link
Contributor

@koivunej koivunej commented Mar 5, 2024

std has had pin! macro for some time, there is no need for us to use the older alternatives. Cannot disallow tokio::pin because tokio macros use that for msrv reasons (didn't check).

@koivunej koivunej requested a review from arpad-m March 5, 2024 09:19
@koivunej koivunej requested a review from a team as a code owner March 5, 2024 09:24
@koivunej koivunej requested a review from khanova March 5, 2024 09:24
@koivunej koivunej enabled auto-merge (squash) March 5, 2024 09:25
@koivunej koivunej changed the title build: clippy disallow pin macros build: clippy disallow futures::pin_mut macro Mar 5, 2024
@koivunej koivunej disabled auto-merge March 5, 2024 09:32
@koivunej koivunej enabled auto-merge (squash) March 5, 2024 09:32
@koivunej koivunej merged commit 752bf5a into main Mar 5, 2024
50 checks passed
@koivunej koivunej deleted the clippy_disallow_pin_macros branch March 5, 2024 10:14
Copy link

github-actions bot commented Mar 5, 2024

2484 tests run: 2361 passed, 0 failed, 123 skipped (full report)


Code coverage* (full report)

  • functions: 28.8% (6959 of 24199 functions)
  • lines: 47.2% (42610 of 90195 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
2c464b2 at 2024-03-05T10:28:18.523Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants