Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: report redis broken message metric #7021

Merged
merged 1 commit into from Mar 5, 2024

Conversation

khanova
Copy link
Contributor

@khanova khanova commented Mar 5, 2024

Problem

Not really a problem. Improving visibility around redis communication.

Summary of changes

Added metric on the number of broken messages.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@khanova khanova requested a review from a team as a code owner March 5, 2024 13:00
Copy link

github-actions bot commented Mar 5, 2024

2484 tests run: 2359 passed, 0 failed, 125 skipped (full report)


Code coverage* (full report)

  • functions: 28.8% (6961 of 24204 functions)
  • lines: 47.2% (42622 of 90225 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
251db85 at 2024-03-05T13:41:34.662Z :recycle:

@khanova khanova merged commit bdbb2f4 into main Mar 5, 2024
53 checks passed
@khanova khanova deleted the proxy-broken-redis-message-metric branch March 5, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants