Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warnings when compiling neon extensions #7053

Merged
merged 3 commits into from Mar 11, 2024
Merged

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Mar 7, 2024

Problem

proceeding #7010, close #6188

Summary of changes

This pull request (should) fix all warnings except -Wdeclaration-after-statement in the neon extension compilation.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@skyzh skyzh requested a review from a team as a code owner March 7, 2024 18:49
@skyzh skyzh requested a review from knizhnik March 7, 2024 18:49
Copy link

github-actions bot commented Mar 7, 2024

2496 tests run: 2373 passed, 0 failed, 123 skipped (full report)


Flaky tests (1)

Postgres 14

  • test_crafted_wal_end[wal_record_crossing_segment_followed_by_small_one]: debug

Code coverage* (full report)

  • functions: 28.8% (7032 of 24443 functions)
  • lines: 47.6% (43449 of 91295 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
b1de758 at 2024-03-11T18:03:21.498Z :recycle:

pgxn/hnsw/hnsw.c Outdated Show resolved Hide resolved
@skyzh skyzh force-pushed the skyzh/fix-remaining-warnings branch from f8c94c3 to a2f3a53 Compare March 11, 2024 13:41
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh force-pushed the skyzh/fix-remaining-warnings branch from a2f3a53 to 9996a38 Compare March 11, 2024 14:48
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh enabled auto-merge (squash) March 11, 2024 15:44
@skyzh skyzh disabled auto-merge March 11, 2024 15:44
@skyzh skyzh enabled auto-merge (squash) March 11, 2024 15:44
@skyzh skyzh merged commit 73a8c97 into main Mar 11, 2024
53 checks passed
@skyzh skyzh deleted the skyzh/fix-remaining-warnings branch March 11, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Compute]: Warnings during the compilation
3 participants