Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: categorise new cplane error message #7057

Merged
merged 1 commit into from Mar 11, 2024

Conversation

conradludgate
Copy link
Contributor

Problem

422 Unprocessable Entity: compute time quota of non-primary branches is exceeded being marked as a control plane error.

Summary of changes

Add the manual checks to make this a user error that should not be retried.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@conradludgate conradludgate requested a review from a team as a code owner March 8, 2024 11:02
@conradludgate conradludgate enabled auto-merge (squash) March 8, 2024 11:02
Copy link

github-actions bot commented Mar 8, 2024

2490 tests run: 2369 passed, 0 failed, 121 skipped (full report)


Flaky tests (2)

Postgres 15

  • test_compute_pageserver_connection_stress: debug
  • test_sharding_split_smoke: debug

Code coverage* (full report)

  • functions: 28.8% (7028 of 24429 functions)
  • lines: 47.6% (43455 of 91330 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
6b01876 at 2024-03-08T12:28:42.120Z :recycle:

@conradludgate conradludgate merged commit cc5d6c6 into main Mar 11, 2024
54 checks passed
@conradludgate conradludgate deleted the proxy-new-cplane-errors branch March 11, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants