Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy http error classification #7098

Merged
merged 6 commits into from Mar 13, 2024
Merged

Conversation

conradludgate
Copy link
Contributor

@conradludgate conradludgate commented Mar 12, 2024

Problem

Missing error classification for SQL-over-HTTP queries.
Not respecting UserFacingError for SQL-over-HTTP queries.

Summary of changes

Adds error classification.
Adds user facing errors.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@conradludgate conradludgate marked this pull request as ready for review March 12, 2024 14:53
@conradludgate conradludgate requested a review from a team as a code owner March 12, 2024 14:53
Copy link

2508 tests run: 2383 passed, 0 failed, 125 skipped (full report)


Flaky tests (1)

Postgres 15

  • test_ondemand_activation: debug

Code coverage* (full report)

  • functions: 28.7% (7027 of 24492 functions)
  • lines: 47.5% (43409 of 91463 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
008c0a7 at 2024-03-12T15:31:41.430Z :recycle:

@conradludgate conradludgate enabled auto-merge (squash) March 12, 2024 15:34
@conradludgate conradludgate merged commit 83855a9 into main Mar 13, 2024
54 checks passed
@conradludgate conradludgate deleted the proxy-http-error-classification branch March 13, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants