Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage controller: validate DNS of registering nodes #7101

Merged
merged 1 commit into from Mar 14, 2024

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Mar 13, 2024

Problem

A node with a bad DNS configuration can register itself with the storage controller, and the controller will try and schedule work onto the node, but never succeed because it can't reach the node.

The DNS case is a special case of asymmetric network issues. The general case isn't covered here -- but might make sense to tighten up after #6844 merges -- then we can avoid assuming a node is immediately available in re_attach.

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added a/tech_debt Area: related to tech debt c/storage/controller Component: Storage Controller labels Mar 13, 2024
@jcsp jcsp requested a review from VladLazar March 13, 2024 09:49
Copy link

2520 tests run: 2395 passed, 0 failed, 125 skipped (full report)


Code coverage* (full report)

  • functions: 28.7% (7028 of 24494 functions)
  • lines: 47.4% (43418 of 91518 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
b27935e at 2024-03-13T10:32:55.627Z :recycle:

@jcsp jcsp marked this pull request as ready for review March 13, 2024 10:36
@jcsp jcsp requested a review from a team as a code owner March 13, 2024 10:36
@jcsp jcsp merged commit 678ed39 into main Mar 14, 2024
60 checks passed
@jcsp jcsp deleted the jcsp/storcon-dns-validate branch March 14, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt c/storage/controller Component: Storage Controller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants