Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: Report warm cold start if connection is from the local cache #7104

Merged
merged 2 commits into from Mar 13, 2024

Conversation

khanova
Copy link
Contributor

@khanova khanova commented Mar 13, 2024

Problem

  • quotes in serialized string
  • no status if connection is from local cache

Summary of changes

  • remove quotes
  • report warm if connection if from local cache

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@khanova khanova requested a review from a team as a code owner March 13, 2024 10:30
@khanova khanova enabled auto-merge (squash) March 13, 2024 11:16
Copy link

2520 tests run: 2396 passed, 0 failed, 124 skipped (full report)


Flaky tests (1)

Postgres 15

  • test_vm_bit_clear_on_heap_lock: release

Code coverage* (full report)

  • functions: 28.7% (7028 of 24495 functions)
  • lines: 47.4% (43411 of 91504 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
6329ca5 at 2024-03-13T11:25:43.563Z :recycle:

@khanova khanova merged commit 0554bee into main Mar 13, 2024
53 checks passed
@khanova khanova deleted the proxy-report-warm-if-connection-is-from-local-cache branch March 13, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants