New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tokio-epoll-uring: fallback to std-fs if not available & not explicitly requested #7120
Merged
problame
merged 10 commits into
main
from
problame/tokio-epoll-uring-availability-detection
Mar 15, 2024
Merged
tokio-epoll-uring: fallback to std-fs if not available & not explicitly requested #7120
problame
merged 10 commits into
main
from
problame/tokio-epoll-uring-availability-detection
Mar 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcsp
approved these changes
Mar 14, 2024
2688 tests run: 2563 passed, 0 failed, 125 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
3db15cd at 2024-03-15T17:51:16.155Z :recycle: |
arpad-m
previously requested changes
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok except typo
skyzh
approved these changes
Mar 14, 2024
Co-authored-by: Arpad Müller <arpad-m@users.noreply.github.com>
arpad-m
approved these changes
Mar 15, 2024
legit clippy failures:
|
…ability-detection' into problame/tokio-epoll-uring-availability-detection
…ability-detection' into problame/tokio-epoll-uring-availability-detection
problame
added a commit
that referenced
this pull request
Mar 15, 2024
problame
added a commit
that referenced
this pull request
Mar 15, 2024
problame
added a commit
that referenced
this pull request
Mar 15, 2024
problame
added a commit
that referenced
this pull request
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7116
Changes:
virtual_file_io_engine
if not explicitly configured in the configtest_pageserver_init_node_id
This needed a tiny bit of tokio-epoll-uring work, hence bumping it.
Changelog: