heavier_once_cell: add detached init support #7135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koivunej
commented
Mar 15, 2024
koivunej
commented
Mar 15, 2024
problame
approved these changes
Mar 15, 2024
I will not be using that method in Layer once my refactorings are in, so might as well. |
2682 tests run: 2557 passed, 0 failed, 125 skipped (full report)Flaky tests (2)Postgres 16
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
d98721a at 2024-03-15T16:26:41.008Z :recycle: |
This was referenced Mar 15, 2024
koivunej
added a commit
that referenced
this pull request
Mar 20, 2024
The second part of work towards fixing `Layer::keep_resident` so that it does not need to repair the internal state. #7135 added a nicer API for initialization. This PR uses it to remove a few indentation levels and the loop construction. The next PR #7175 will use the refactorings done in this PR, and always initialize the internal state after a download. Cc: #5331
koivunej
added a commit
that referenced
this pull request
Mar 20, 2024
Before this PR, cancellation for `LayerInner::get_or_maybe_download` could occur so that we have downloaded the layer file in the filesystem, but because of the cancellation chance, we have not set the internal `LayerInner::inner` or initialized the state. With the detached init support introduced in #7135 and in place in #7152, we can now initialize the internal state after successfully downloading in the spawned task. The next PR will fix the remaining problems that this PR leaves: - `Layer::keep_resident` is still used because - `Layer::get_or_maybe_download` always cancels an eviction, even when canceled Split off from #7030. Stacked on top of #7152. Cc: #5331.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aiming for the design where
heavier_once_cell::OnceCellis initialized by a future factory lead to awkwardness with howLayerInner::get_or_maybe_downloadlooks right now with theloop. The loop helps with two situations:LayerInner::get_or_maybe_downloadthat canceled a pending eviction was canceled leaving theheavier_once_cell::OnceCelluninitialized but needing repair by the nextLayerInner::get_or_maybe_downloadBy instead supporting detached initialization in
heavier_once_cell::OnceCellvia anOnceCell::get_or_detached_init, we can fix what the monolithic #7030 does:heavier_once_cell::OnceCellregardless of the download starter being canceledLayerInner::get_or_maybe_downloadno longer stops eviction but can win it if not canceledSplit off from #7030.
Cc: #5331