Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layer): metric miscalculations #7137

Merged
merged 5 commits into from Mar 15, 2024
Merged

fix(layer): metric miscalculations #7137

merged 5 commits into from Mar 15, 2024

Conversation

koivunej
Copy link
Contributor

Split off from #7030:

  • each early exit is counted as canceled init, even though it most likely was just LayerInner::keep_resident doing the no-download repair check
  • downloaded_after could had been accounted for multiple times, and also when repairing to match on-disk state

Cc: #5331

there was a chance of it being double-accounted and accounted for
cancelled evictions.
this was already implemented in #7051.
@koivunej koivunej requested a review from a team as a code owner March 15, 2024 11:03
@koivunej koivunej requested a review from jcsp March 15, 2024 11:03
Copy link

2682 tests run: 2560 passed, 0 failed, 122 skipped (full report)


Code coverage* (full report)

  • functions: 28.3% (7031 of 24809 functions)
  • lines: 47.1% (43494 of 92433 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
b795eda at 2024-03-15T11:52:20.279Z :recycle:

@koivunej koivunej merged commit bf187aa into main Mar 15, 2024
53 checks passed
@koivunej koivunej deleted the joonas/layer_metric_fixes branch March 15, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants