Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixup(#7160 / tokio_epoll_uring_ext): double-panic caused by info! in thread-local's drop() #7164

Merged
merged 2 commits into from
Mar 18, 2024
Merged

fixup(#7160 / tokio_epoll_uring_ext): double-panic caused by info! in thread-local's drop() #7164

merged 2 commits into from
Mar 18, 2024

Commits on Mar 18, 2024

  1. fixup(#7160 / tokio_epoll_uring_ext): double-panic caused by info! in… 

    … thread-local's drop()

Manual testing of the changes in #7160 revealed that, if the
thread-local destructor ever runs (it apparently doesn't in our test
suite runs, otherwise #7160 would not have auto-merged), we can
encounter an `abort()` due to a double-panic in the tracing code.

This github comment here contains the stack trace:
#7160 (comment)

This PR reverts #7160 and uses a atomic counter to identify the
thread-local in log messages, instead of the memory address of the
thread local, which may be re-used.
    @problame
    problame committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    cdccb22 View commit details
    Browse the repository at this point in the history

  2. avoid OnceCell

    @problame
    problame committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    01bf967 View commit details
    Browse the repository at this point in the history