Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup(#7168): neon_local: use pageserver defaults for known but unspecified config overrides #7166

Merged
merged 2 commits into from Mar 19, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Mar 18, 2024

Problem

e2e tests cannot run on macOS unless the file engine env var is supplied.

./scripts/pytest test_runner/regress/test_neon_superuser.py -s

will fail with tokio-epoll-uring not supported.

This is because we persist the file engine config by default. In this pull request, we only persist when someone specifies it, so that it can use the default platform-variant config in the page server.

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested a review from problame March 18, 2024 17:36
Copy link

github-actions bot commented Mar 18, 2024

2700 tests run: 2570 passed, 0 failed, 130 skipped (full report)


Code coverage* (full report)

  • functions: 28.3% (7128 of 25166 functions)
  • lines: 46.8% (43694 of 93287 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
0dc7fb3 at 2024-03-18T21:11:48.870Z :recycle:

Copy link
Contributor

@problame problame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Please apply the same changes to get_vectored_impl, and adjust this PR's title & description to sth like

fixup(#7120): neon_local: use pageserver defaults for known but unspecified config overrides

@skyzh skyzh changed the title neon_local: fix file engine on macOS fixup(#7168): neon_local: use pageserver defaults for known but unspecified config overrides Mar 18, 2024
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh merged commit a8384a0 into main Mar 19, 2024
53 checks passed
@skyzh skyzh deleted the skyzh/neon-local-no-override branch March 19, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants