Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async password validation #7171

Merged
merged 1 commit into from
Mar 18, 2024
Merged

async password validation #7171

merged 1 commit into from
Mar 18, 2024

Conversation

conradludgate
Copy link
Contributor

Problem

password hashing can block main thread

Summary of changes

spawn_blocking the password hash call

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@conradludgate conradludgate requested a review from a team as a code owner March 18, 2024 20:38
@conradludgate conradludgate enabled auto-merge (squash) March 18, 2024 20:40
Copy link

2700 tests run: 2568 passed, 0 failed, 132 skipped (full report)


Code coverage* (full report)

  • functions: 28.3% (7132 of 25170 functions)
  • lines: 46.9% (43712 of 93291 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
b934c37 at 2024-03-18T21:25:04.098Z :recycle:

@conradludgate conradludgate merged commit 49be446 into main Mar 18, 2024
53 checks passed
@conradludgate conradludgate deleted the proxy-blocking branch March 18, 2024 22:57
conradludgate added a commit that referenced this pull request Mar 21, 2024
## Problem

spawn_blocking in #7171 was a hack

## Summary of changes

neondatabase/rust-postgres#29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants