Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: extra debug for test_secondary_downloads failures #7183

Merged
merged 2 commits into from Mar 20, 2024

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Mar 20, 2024

  • Enable debug logs for this test
  • Add some debug logging detail in downloader.rs
  • Add an info-level message in scheduler.rs that makes it obvious if a command is waiting for an existing task rather than spawning a new one.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added c/storage/pageserver Component: storage: pageserver a/tech_debt Area: related to tech debt labels Mar 20, 2024
@jcsp jcsp requested a review from a team as a code owner March 20, 2024 10:41
@jcsp jcsp requested a review from problame March 20, 2024 10:41
Copy link

2706 tests run: 2575 passed, 0 failed, 131 skipped (full report)


Flaky tests (2)

Postgres 16

  • test_vm_bit_clear_on_heap_lock: debug

Postgres 15

  • test_timeline_size_quota_on_startup: release

Code coverage* (full report)

  • functions: 28.3% (7131 of 25202 functions)
  • lines: 46.9% (43712 of 93300 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
c1691e6 at 2024-03-20T11:26:06.380Z :recycle:

@jcsp jcsp merged commit 2726b19 into main Mar 20, 2024
56 checks passed
@jcsp jcsp deleted the jcsp/secondary-downloads-debug branch March 20, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt c/storage/pageserver Component: storage: pageserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants