Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: enable sha2 asm support #7184

Merged
merged 1 commit into from Mar 20, 2024
Merged

proxy: enable sha2 asm support #7184

merged 1 commit into from Mar 20, 2024

Conversation

conradludgate
Copy link
Contributor

@conradludgate conradludgate commented Mar 20, 2024

Problem

faster sha2 hashing.

Summary of changes

enable asm feature for sha2. this feature will be default in sha2 0.11, so we might as well lean into it now. It provides a noticeable speed boost on macos aarch64. Haven't tested on x86 though

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@conradludgate conradludgate requested a review from a team as a code owner March 20, 2024 10:53
Copy link

2706 tests run: 2575 passed, 0 failed, 131 skipped (full report)


Code coverage* (full report)

  • functions: 28.3% (7131 of 25197 functions)
  • lines: 46.9% (43717 of 93289 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
9110c5b at 2024-03-20T11:40:54.603Z :recycle:

Copy link

@stradig stradig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conradludgate conradludgate merged commit 6d99642 into main Mar 20, 2024
53 checks passed
@conradludgate conradludgate deleted the proxy-sha2-asm branch March 20, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants