New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement Serialize/Deserialize for SystemTime with RFC3339 format #7203
implement Serialize/Deserialize for SystemTime with RFC3339 format #7203
Conversation
Thanks Kevin - @VladLazar could you review please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Looks good to me (just one minor nit).
2754 tests run: 2630 passed, 0 failed, 124 skipped (full report)Flaky tests (2)Postgres 16
Postgres 15
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
36bb8dd at 2024-04-08T10:30:42.879Z :recycle: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevinmingtarja looks like your PR raced with a change to the utilization endpoint. Could you please update your branch? I'll run CI again after that and merge it.
Got it, I just updated my branch and resolved the merge conflict. |
@kevinmingtarja thanks for the PR! |
Problem
We have two places that use a helper (
ser_rfc3339_millis
) to get serde to stringify SystemTimes into the desired format.Summary of changes
Created a new module
utils::serde_system_time
and inside it a wrapper typeSystemTime
forstd::time::SystemTime
that serializes/deserializes to the RFC3339 format.This new type is then used in the two places that were previously using the helper for serialization, thereby eliminating the need to decorate structs.
Closes #7151.