Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test_pageserver_recovery flakyness #7207

Merged
merged 7 commits into from Mar 25, 2024
Merged

test: fix test_pageserver_recovery flakyness #7207

merged 7 commits into from Mar 25, 2024

Conversation

VladLazar
Copy link
Contributor

@VladLazar VladLazar commented Mar 22, 2024

Problem

We recently introduced log file validation for the storage controller. The heartbeater will WARN when it fails
for a node, hence the test fails.

Closes #7159

Summary of changes

  • Warn only once for each set of heartbeat retries
  • Allow list heartbeat warns

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented Mar 22, 2024

2718 tests run: 2580 passed, 0 failed, 138 skipped (full report)


Flaky tests (1)

Postgres 16

  • test_timeline_size_quota_on_startup: release

Code coverage* (full report)

  • functions: 28.2% (6289 of 22336 functions)
  • lines: 46.9% (44180 of 94150 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
cf1797b at 2024-03-23T18:15:24.885Z :recycle:

@VladLazar VladLazar changed the title test: fix `test_pageserver_recovery flakyness test: fix test_pageserver_recovery flakyness Mar 22, 2024
@VladLazar
Copy link
Contributor Author

120 runs of the test with no failures here. Seems stable.

@VladLazar VladLazar marked this pull request as ready for review March 23, 2024 17:28
@VladLazar VladLazar requested a review from a team as a code owner March 23, 2024 17:28
@VladLazar VladLazar requested review from arpad-m and jcsp March 23, 2024 17:28
@VladLazar VladLazar merged commit 3a4ebfb into main Mar 25, 2024
54 checks passed
@VladLazar VladLazar deleted the vlad/fix-7159 branch March 25, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_pageserver_recovery is flaky
2 participants