Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: reuse sess_id as request_id for the cplane requests #7245

Merged
merged 2 commits into from Mar 26, 2024

Conversation

khanova
Copy link
Contributor

@khanova khanova commented Mar 26, 2024

Problem

https://github.com/neondatabase/cloud/issues/11599

Summary of changes

Reuse the same sess_id for requests within the one session.

TODO: get rid of session_id in query params.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@khanova khanova requested review from a team as code owners March 26, 2024 10:56
@khanova khanova requested review from stradig and removed request for a team and skyzh March 26, 2024 10:57
@khanova khanova enabled auto-merge (squash) March 26, 2024 10:59
@khanova khanova merged commit 6c18109 into main Mar 26, 2024
46 of 47 checks passed
@khanova khanova deleted the proxy-reuse-same-sess-id branch March 26, 2024 11:27
Copy link

2718 tests run: 2582 passed, 0 failed, 136 skipped (full report)


Flaky tests (1)

Postgres 14

  • test_timeline_size_quota_on_startup: release

Code coverage* (full report)

  • functions: 28.1% (6286 of 22345 functions)
  • lines: 47.0% (44213 of 94093 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
ca06e60 at 2024-03-26T11:40:52.273Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants