Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry loops and bump test timeout in test_pageserver_connection_stress #7281

Merged
merged 2 commits into from
May 2, 2024

Conversation

save-buffer
Copy link
Contributor

Problem

Test is still flaky due to two issues: test sometimes times out after 300 sec, and sometimes it fails because a query gets canceled due to it timing out.

Summary of changes

Bumps test timeout and retries queries if they get canceled.

Copy link

github-actions bot commented Mar 29, 2024

2856 tests run: 2735 passed, 0 failed, 121 skipped (full report)


Flaky tests (2)

Postgres 16

  • test_vm_bit_clear_on_heap_lock: debug

Postgres 15

  • test_empty_branch_remote_storage_upload: debug

Code coverage* (full report)

  • functions: 28.0% (6600 of 23537 functions)
  • lines: 46.7% (46860 of 100326 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
ed0199a at 2024-05-01T22:10:53.767Z :recycle:

Copy link
Member

@tristan957 tristan957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add info into the commit description about why this commit exists? Seems like you added some good info in the PR description.

test_runner/regress/test_bad_connection.py Show resolved Hide resolved
test_runner/regress/test_bad_connection.py Outdated Show resolved Hide resolved
@save-buffer
Copy link
Contributor Author

Won't the PR description get put into the commit that gets merged into main?

@tristan957
Copy link
Member

Won't the PR description get put into the commit that gets merged into main?

Depends how you merge it :)

@save-buffer save-buffer merged commit d43d773 into main May 2, 2024
53 checks passed
@save-buffer save-buffer deleted the sasha_bump_timeout branch May 2, 2024 04:36
@save-buffer
Copy link
Contributor Author

I have used the squash and merge button, just how you like it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants