-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retry loops and bump test timeout in test_pageserver_connection_stress #7281
Conversation
2856 tests run: 2735 passed, 0 failed, 121 skipped (full report)Flaky tests (2)Postgres 16
Postgres 15
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
ed0199a at 2024-05-01T22:10:53.767Z :recycle: |
5b9b331
to
a496340
Compare
a496340
to
c4c90b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add info into the commit description about why this commit exists? Seems like you added some good info in the PR description.
2f958c8
to
ed0199a
Compare
Won't the PR description get put into the commit that gets merged into main? |
Depends how you merge it :) |
I have used the squash and merge button, just how you like it! |
Problem
Test is still flaky due to two issues: test sometimes times out after 300 sec, and sometimes it fails because a query gets canceled due to it timing out.
Summary of changes
Bumps test timeout and retries queries if they get canceled.