Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: update mgmt_api to use TenantShardId #7313

Merged
merged 1 commit into from Apr 4, 2024

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Apr 4, 2024

Problem

The API client was written around the same time as some of the server APIs changed from TenantId to TenantShardId

Closes: #6154

Summary of changes

  • Refactor mgmt_api timeline_info and keyspace methods to use TenantShardId to match the server

This doesn't make pagebench sharding aware, but it paves the way to do so later.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added c/storage/pageserver Component: storage: pageserver a/tech_debt Area: related to tech debt labels Apr 4, 2024
Copy link

github-actions bot commented Apr 4, 2024

2748 tests run: 2624 passed, 0 failed, 124 skipped (full report)


Code coverage* (full report)

  • functions: 27.9% (6380 of 22848 functions)
  • lines: 46.8% (44982 of 96060 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
3b66900 at 2024-04-04T12:10:22.268Z :recycle:

@jcsp jcsp marked this pull request as ready for review April 4, 2024 12:13
@jcsp jcsp requested a review from a team as a code owner April 4, 2024 12:13
@jcsp jcsp requested a review from koivunej April 4, 2024 12:13
@jcsp jcsp merged commit e17bc6a into main Apr 4, 2024
57 checks passed
@jcsp jcsp deleted the jcsp/issue-6154-mgmt_api branch April 4, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt c/storage/pageserver Component: storage: pageserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pageserver_client::mgmt_api: use TenantShardId instead of TenantId
2 participants