Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zero segment upload #7318

Merged
merged 1 commit into from Apr 5, 2024
Merged

Fix zero segment upload #7318

merged 1 commit into from Apr 5, 2024

Conversation

petuhovskiy
Copy link
Member

Found these logs on staging:

INFO Partial backup{ttid=X/Y}: failed to upload 000000010000000000000000_173_0000000000000000_0000000000000000_sk56.partial: Failed to open file "/storage/safekeeper/data/X/Y/000000010000000000000000.partial" for wal backup: No such file or directory (os error 2)
INFO Partial backup{ttid=X/Y}:upload{name=000000010000000000000000_173_0000000000000000_0000000000000000_sk56.partial}: starting upload PartialRemoteSegment { status: InProgress, name: "000000010000000000000000_173_0000000000000000_0000000000000000_sk56.partial", commit_lsn: 0/0, flush_lsn: 0/0, term: 173 }

This is because partial backup tries to upload zero segment when there is no data in timeline. This PR fixes this bug introduced in #6530.

@petuhovskiy petuhovskiy requested a review from a team as a code owner April 4, 2024 14:20
@petuhovskiy petuhovskiy requested a review from arssher April 4, 2024 14:20
Copy link

github-actions bot commented Apr 4, 2024

2748 tests run: 2624 passed, 0 failed, 124 skipped (full report)


Flaky tests (1)

Postgres 16

  • test_vm_bit_clear_on_heap_lock: debug

Code coverage* (full report)

  • functions: 27.9% (6380 of 22850 functions)
  • lines: 46.8% (44982 of 96062 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
9d4f858 at 2024-04-04T15:29:14.226Z :recycle:

@petuhovskiy petuhovskiy merged commit 8ceb4f0 into main Apr 5, 2024
53 checks passed
@petuhovskiy petuhovskiy deleted the fix-partial-backup-0 branch April 5, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants