Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: extend log allow list in test_storcon_cli #7321

Merged
merged 1 commit into from Apr 5, 2024
Merged

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Apr 4, 2024

This test was occasionally flaky: it already allowed the log for the scheduler complaining about Stop state, but not the log for maybe_reconcile complaining.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added a/test Area: related to testing c/storage/controller Component: Storage Controller labels Apr 4, 2024
Copy link

github-actions bot commented Apr 4, 2024

2748 tests run: 2624 passed, 0 failed, 124 skipped (full report)


Code coverage* (full report)

  • functions: 28.0% (6394 of 22862 functions)
  • lines: 46.8% (44981 of 96052 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
0c63bac at 2024-04-04T17:13:46.649Z :recycle:

@jcsp jcsp enabled auto-merge (squash) April 4, 2024 17:24
@jcsp jcsp changed the title tests: extend low allow list in test_storcon_cli tests: extend log allow list in test_storcon_cli Apr 4, 2024
@jcsp jcsp requested a review from VladLazar April 4, 2024 17:25
@jcsp jcsp disabled auto-merge April 5, 2024 10:44
@jcsp jcsp merged commit 6019cce into main Apr 5, 2024
56 checks passed
@jcsp jcsp deleted the jcsp/storcon-cli-test branch April 5, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/test Area: related to testing c/storage/controller Component: Storage Controller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants