Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update measured with some more convenient features #7334

Merged
merged 5 commits into from Apr 8, 2024

Conversation

conradludgate
Copy link
Contributor

@conradludgate conradludgate commented Apr 6, 2024

Problem

Some awkwardness in the measured API.
Missing process metrics.

Summary of changes

Update measured to use the new convenience setup features.
Added measured-process lib.
Added measured support for libmetrics

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented Apr 6, 2024

2754 tests run: 2636 passed, 0 failed, 118 skipped (full report)


Code coverage* (full report)

  • functions: 28.1% (6424 of 22882 functions)
  • lines: 46.8% (45086 of 96323 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
d5b62e8 at 2024-04-08T18:14:48.957Z :recycle:

@conradludgate conradludgate force-pushed the update-measured-0-0-16 branch 2 times, most recently from 898d8ea to 8af1a88 Compare April 8, 2024 10:28
@conradludgate conradludgate marked this pull request as ready for review April 8, 2024 16:15
@conradludgate conradludgate requested a review from a team as a code owner April 8, 2024 16:15
Copy link
Contributor

@VladLazar VladLazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thank you, Conrad - hakari seems somewhat unhappy though

@conradludgate conradludgate enabled auto-merge (squash) April 8, 2024 17:31
@conradludgate conradludgate merged commit f212630 into main Apr 8, 2024
48 checks passed
@conradludgate conradludgate deleted the update-measured-0-0-16 branch April 8, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants