Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: further stabilize test_deletion_queue_recovery #7335

Merged
merged 5 commits into from Apr 7, 2024

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Apr 6, 2024

This is the other main failure mode called out in #6092 , that the test can shut down the pageserver while it has "future layers" in the index, and that this results in unexpected stats after restart.

We can avoid this nondeterminism by shutting down the endpoint, flushing everything from SK to PS, checkpointing, and then waiting for that final LSN to be uploaded. This is more heavyweight than most of our tests require, but useful in the case of tests that expect a particular behavior after restart wrt layer deletions.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added c/storage/pageserver Component: storage: pageserver a/test Area: related to testing a/tech_debt Area: related to tech debt labels Apr 6, 2024
@jcsp jcsp requested a review from arpad-m April 6, 2024 20:48
Copy link

github-actions bot commented Apr 6, 2024

2754 tests run: 2630 passed, 0 failed, 124 skipped (full report)


Flaky tests (1)

Postgres 14

  • test_ts_of_lsn_api: debug

Code coverage* (full report)

  • functions: 28.0% (6405 of 22857 functions)
  • lines: 46.9% (45089 of 96237 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
de7a7ec at 2024-04-07T21:34:21.443Z :recycle:

@jcsp jcsp enabled auto-merge (squash) April 7, 2024 17:07
@jcsp jcsp merged commit 0788760 into main Apr 7, 2024
49 checks passed
@jcsp jcsp deleted the jcsp/issue-6092-quiesce branch April 7, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt a/test Area: related to testing c/storage/pageserver Component: storage: pageserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants