Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read cplane events from regional redis #7352

Merged
merged 15 commits into from Apr 11, 2024
Merged

Conversation

khanova
Copy link
Contributor

@khanova khanova commented Apr 10, 2024

Problem

Actually read redis events.

Summary of changes

This is revert of #7350 + fixes. So, it makes sense to review everything except the first commit: https://github.com/neondatabase/neon/pull/7352/files/4ac8eddacdd5894e162f29b728b208d69d4c1832..83ba900fc6a67ed7fe0385e1f22ddc7fef754436

  • Fixed events parsing
  • Added timeout after connection failure
  • Separated regional and global redis clients.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@khanova khanova force-pushed the proxy-read-from-redis-fixes branch from 4be55e5 to e2287ca Compare April 10, 2024 10:56
Copy link

github-actions bot commented Apr 10, 2024

2748 tests run: 2630 passed, 0 failed, 118 skipped (full report)


Flaky tests (1)

Postgres 14

  • test_ts_of_lsn_api: debug

Code coverage* (full report)

  • functions: 28.0% (6428 of 22958 functions)
  • lines: 46.6% (45017 of 96547 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
9261280 at 2024-04-11T18:37:43.251Z :recycle:

@khanova khanova changed the title Fix Read cplane events from regional redis Apr 11, 2024
@khanova khanova marked this pull request as ready for review April 11, 2024 14:20
@khanova khanova requested a review from a team as a code owner April 11, 2024 14:20
@khanova khanova enabled auto-merge (squash) April 11, 2024 18:15
@khanova khanova merged commit 40f15c3 into main Apr 11, 2024
48 of 49 checks passed
@khanova khanova deleted the proxy-read-from-redis-fixes branch April 11, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants