Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: fix overloaded db connection closure #7364

Merged
merged 1 commit into from Apr 11, 2024

Conversation

conradludgate
Copy link
Contributor

Problem

possible for the database connections to not close in time.

Summary of changes

force the closing of connections if the client has hung up

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@conradludgate conradludgate marked this pull request as ready for review April 11, 2024 20:05
@conradludgate conradludgate requested a review from a team as a code owner April 11, 2024 20:05
@conradludgate conradludgate enabled auto-merge (squash) April 11, 2024 20:09
Copy link
Contributor

@khanova khanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

github-actions bot commented Apr 11, 2024

2772 tests run: 2654 passed, 0 failed, 118 skipped (full report)


Flaky tests (1)

Postgres 14

Code coverage* (full report)

  • functions: 28.0% (6428 of 22962 functions)
  • lines: 46.6% (45019 of 96565 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
58b1b17 at 2024-04-11T21:09:04.405Z :recycle:

@conradludgate conradludgate merged commit e92fb94 into main Apr 11, 2024
53 of 54 checks passed
@conradludgate conradludgate deleted the proxy-fix-cancellation branch April 11, 2024 20:55
conradludgate added a commit that referenced this pull request Apr 11, 2024
## Problem

possible for the database connections to not close in time.

## Summary of changes

force the closing of connections if the client has hung up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants