Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(compute_ctl): add error context to apply_spec #7374

Merged
merged 1 commit into from Apr 17, 2024
Merged

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Apr 14, 2024

Problem

Make it faster to identify which part of apply spec goes wrong by adding an error context.

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested review from a team as code owners April 14, 2024 12:53
Copy link

2748 tests run: 2630 passed, 0 failed, 118 skipped (full report)


Code coverage* (full report)

  • functions: 28.0% (6429 of 22965 functions)
  • lines: 46.6% (45021 of 96587 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
d121b88 at 2024-04-14T13:35:57.836Z :recycle:

@skyzh skyzh merged commit cb4b40f into main Apr 17, 2024
52 of 53 checks passed
@skyzh skyzh deleted the skyzh/spec-error branch April 17, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants