Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: Exclude private ip errors from recorded metrics #7389

Merged
merged 3 commits into from Apr 15, 2024

Conversation

khanova
Copy link
Contributor

@khanova khanova commented Apr 15, 2024

Problem

Right now we record errors from internal VPC.

Summary of changes

  • Exclude it from the metrics.
  • Simplify pg-sni-router

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@khanova khanova requested a review from a team as a code owner April 15, 2024 14:46
Copy link

github-actions bot commented Apr 15, 2024

2748 tests run: 2630 passed, 0 failed, 118 skipped (full report)


Flaky tests (1)

Postgres 14

  • test_compute_pageserver_connection_stress: release

Code coverage* (full report)

  • functions: 28.0% (6429 of 22940 functions)
  • lines: 46.6% (45029 of 96589 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
cea9332 at 2024-04-15T16:28:15.531Z :recycle:

Copy link
Contributor

@conradludgate conradludgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks fine, just nit pick on the lockfile

Cargo.lock Outdated Show resolved Hide resolved
@khanova khanova merged commit 110282e into main Apr 15, 2024
55 checks passed
@khanova khanova deleted the proxy-exclude-errors-from-private-ip branch April 15, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants