Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: demote range end fallback log #7403

Merged
merged 1 commit into from Apr 17, 2024

Conversation

VladLazar
Copy link
Contributor

@VladLazar VladLazar commented Apr 17, 2024

Problem

This trace is emitted whenever a vectored read touches the end of a delta layer file. It's a perfectly normal case, but I expected it to be more rare when implementing the code.

Summary of changes

Demote log to debug.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Problem
This trace is emitted whenver a vectored read touches the end
of a delta layer file. It's a perfectly normal case, but I expected
it to be more rare when implementing the code.

Summary of Changes
Demote log to debug.
@VladLazar VladLazar requested a review from a team as a code owner April 17, 2024 09:20
@VladLazar VladLazar requested review from jcsp and problame and removed request for jcsp April 17, 2024 09:20
Copy link

2760 tests run: 2642 passed, 0 failed, 118 skipped (full report)


Code coverage* (full report)

  • functions: 27.9% (6395 of 22950 functions)
  • lines: 46.4% (44730 of 96488 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
55e8ef4 at 2024-04-17T10:23:26.948Z :recycle:

@VladLazar VladLazar merged commit 3023de1 into main Apr 17, 2024
52 of 53 checks passed
@VladLazar VladLazar deleted the vlad/tone-down-range-fallback-log branch April 17, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants