Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: Improve logging #7405

Merged
merged 5 commits into from Apr 17, 2024
Merged

proxy: Improve logging #7405

merged 5 commits into from Apr 17, 2024

Conversation

khanova
Copy link
Contributor

@khanova khanova commented Apr 17, 2024

Problem

It's unclear from logs what's going on with the regional redis.

Summary of changes

Make logs better.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@khanova khanova requested a review from a team as a code owner April 17, 2024 10:40
proxy/src/cache/endpoints.rs Outdated Show resolved Hide resolved
proxy/src/cache/endpoints.rs Outdated Show resolved Hide resolved
proxy/src/context.rs Outdated Show resolved Hide resolved
@khanova khanova enabled auto-merge (squash) April 17, 2024 11:00
@khanova khanova merged commit fd49005 into main Apr 17, 2024
43 of 44 checks passed
@khanova khanova deleted the proxy-improve-loggign branch April 17, 2024 11:33
Copy link

2760 tests run: 2642 passed, 0 failed, 118 skipped (full report)


Code coverage* (full report)

  • functions: 27.9% (6396 of 22958 functions)
  • lines: 46.3% (44731 of 96516 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
f962772 at 2024-04-17T11:40:50.843Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants