pagectl draw-timeline-dir: include layer file name as an SVG comment #7455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs #7452 Also, drive-by improve the usage instructions with commands I found useful during that incident. The forked repository is being upstreamed, but, in the meantime, let's commit this work.
2772 tests run: 2654 passed, 0 failed, 118 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
98a7820 at 2024-04-22T13:02:45.418Z :recycle: |
2 tasks
arpad-m
approved these changes
Apr 22, 2024
VladLazar
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7452
Also, drive-by improve the usage instructions with commands I found
useful during that incident.
The patch in the fork of
svg_fmtis being upstreamed, but, in the meantime,let's commit what we have because it was useful during the incident.