Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage_controller: wait for db on startup #7479

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Apr 23, 2024

Problem

In some dev/test environments, there aren't health checks to guarantee the database is available before starting the controller. This creates friction for the developer.

Summary of changes

  • Wait up to 5 seconds for the database to become available on startup

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added t/feature Issue type: feature, for new features or requests c/storage/controller Component: Storage Controller labels Apr 23, 2024
@jcsp jcsp requested a review from mattpodraza April 23, 2024 12:26
@jcsp jcsp requested a review from a team as a code owner April 23, 2024 12:26
@jcsp jcsp requested a review from petuhovskiy April 23, 2024 12:26
Copy link

2760 tests run: 2642 passed, 0 failed, 118 skipped (full report)


Flaky tests (1)

Postgres 16

  • test_vm_bit_clear_on_heap_lock: debug

Code coverage* (full report)

  • functions: 28.1% (6465 of 23045 functions)
  • lines: 46.8% (45678 of 97609 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
cb22372 at 2024-04-23T13:09:29.855Z :recycle:

@jcsp jcsp merged commit 8426fb8 into main Apr 23, 2024
56 checks passed
@jcsp jcsp deleted the jcsp/storcon-wait-for-db branch April 23, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/storage/controller Component: Storage Controller t/feature Issue type: feature, for new features or requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants