refactor(ephemeral_file): reuse owned_buffers_io::BufferedWriter #7484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs-io/refactor-buffered-writer
…ver underlying writer
…op cache-on-write
2 tasks
2796 tests run: 2676 passed, 0 failed, 120 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
5115aab at 2024-04-26T10:19:19.539Z :recycle: |
…r' into problame/larger-buffers-io/refactor-ephemeral-file-reuse-buffered-io
problame
commented
Apr 23, 2024
VladLazar
reviewed
Apr 24, 2024
pageserver/src/tenant/ephemeral_file/zero_padded_read_write/zero_padded_buffer.rs
Outdated
Show resolved
Hide resolved
pageserver/src/tenant/ephemeral_file/zero_padded_read_write/zero_padded_buffer.rs
Outdated
Show resolved
Hide resolved
pageserver/src/tenant/ephemeral_file/zero_padded_read_write/zero_padded_buffer.rs
Outdated
Show resolved
Hide resolved
VladLazar
approved these changes
Apr 25, 2024
…rs-io/refactor-buffered-writer
…to problame/larger-buffers-io/refactor-size-tracking-writer
…r' into problame/larger-buffers-io/refactor-ephemeral-file-reuse-buffered-io
…or-ephemeral-file-reuse-buffered-io' into problame/larger-buffers-io/refactor-ephemeral-file-reuse-buffered-io--with-write-path-prewarming
…rs-io/refactor-buffered-writer
…to problame/larger-buffers-io/refactor-size-tracking-writer
…r' into problame/larger-buffers-io/refactor-ephemeral-file-reuse-buffered-io
…e-buffered-io' into problame/larger-buffers-io/refactor-ephemeral-file-reuse-buffered-io--with-write-path-prewarming
…/refactor-ephemeral-file-reuse-buffered-io--with-write-path-prewarming refactor(ephemeral_file): bring back pre-warming of PS page cache on write
problame
changed the title
Base automatically changed from
problame/larger-buffers-io/refactor-size-tracking-writer
to
main
April 26, 2024 09:19
…rs-io/refactor-buffered-writer
…to problame/larger-buffers-io/refactor-size-tracking-writer
…r' into problame/larger-buffers-io/refactor-ephemeral-file-reuse-buffered-io
problame
deleted the
problame/larger-buffers-io/refactor-ephemeral-file-reuse-buffered-io
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #7124
Changes
This PR replaces the
EphemeralFile::write_blob-specifcstruct Writerwith re-use of
owned_buffers_io::write::BufferedWriter.Further, it restructures the code to cleanly separate