Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pagserver: use vectored read path in benchmarks #7498

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

VladLazar
Copy link
Contributor

@VladLazar VladLazar commented Apr 24, 2024

Problem

Benchmarks don't use the vectored read path.

Summary of changes

  • Update the benchmarks to use the vectored read path for both singular and vectored gets.
  • Disable validation for the benchmarks

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@VladLazar VladLazar added the run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label label Apr 24, 2024
@VladLazar VladLazar force-pushed the vlad/coalesce-read-paths-test-bench branch 2 times, most recently from 61b8a8b to da96468 Compare April 24, 2024 15:53
Copy link

github-actions bot commented Apr 24, 2024

2876 tests run: 2742 passed, 0 failed, 134 skipped (full report)


Flaky tests (1)

Postgres 15

  • test_partial_evict_tenant[relative_spare]: release

Code coverage* (full report)

  • functions: 28.3% (6546 of 23138 functions)
  • lines: 47.0% (46220 of 98421 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
8e26c16 at 2024-04-29T09:46:45.238Z :recycle:

@VladLazar VladLazar mentioned this pull request Apr 24, 2024
5 tasks
@VladLazar VladLazar changed the base branch from main to vlad/coalesce-read-paths-test April 24, 2024 17:05
@VladLazar VladLazar changed the title Vlad/coalesce read paths test bench pagserver: use vectored get in benchmarks Apr 24, 2024
Base automatically changed from vlad/coalesce-read-paths-test to main April 25, 2024 12:29
@VladLazar VladLazar added the forward compatibility breakage Broken forward compatibility. The previous version can't handle new data. It'll be hard to roll-back label Apr 25, 2024
@VladLazar VladLazar force-pushed the vlad/coalesce-read-paths-test-bench branch 2 times, most recently from b91821a to fb9ecac Compare April 25, 2024 17:18
@VladLazar VladLazar removed the forward compatibility breakage Broken forward compatibility. The previous version can't handle new data. It'll be hard to roll-back label Apr 25, 2024
@VladLazar VladLazar force-pushed the vlad/coalesce-read-paths-test-bench branch from fb9ecac to 8e26c16 Compare April 26, 2024 13:59
@VladLazar VladLazar changed the title pagserver: use vectored get in benchmarks pagserver: use vectored read path in benchmarks Apr 29, 2024
@VladLazar VladLazar marked this pull request as ready for review April 29, 2024 09:22
@VladLazar VladLazar merged commit 1f417af into main Apr 29, 2024
62 checks passed
@VladLazar VladLazar deleted the vlad/coalesce-read-paths-test-bench branch April 29, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants