-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore page header when comparing VM pages in test_vm_bits.py #7499
Conversation
This sounds scary. Why does that happen? |
Also, this is about a VM page; how is replacing an empty heap page with an all-zeros page related to this? |
3024 tests run: 2891 passed, 0 failed, 133 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
de9a33f at 2024-05-08T16:40:08.424Z :recycle: |
Is anything blocking this? I notice it doesn't have a reviewer assigned. Chasing because it's the most frequent failure in the suite. |
Sorry, you are right. It is not somehow related to VM.
So despite to the fact that my explanation of the source of the problem were not correct, this PR is still relevant. |
I don't know Postgres internals but the explanation of why header is different sounds reasonable. Approving to make test suites more stable. |
3b5876c
to
de9a33f
Compare
## Problem See #6714, #6967 ## Summary of changes Completely ignore page header when comparing VM pages. ## Checklist before requesting a review - [ ] I have performed a self-review of my code. - [ ] If it is a core feature, I have added thorough tests. - [ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard? - [ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section. ## Checklist before merging - [ ] Do not forget to reformat commit message to not include the above checklist Co-authored-by: Konstantin Knizhnik <knizhnik@neon.tech>
Problem
See #6714, #6967
Summary of changes
Completely ignore page header when comparing VM pages.
Checklist before requesting a review
Checklist before merging