Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pageserver): temporary metrics on ingestion time #7515

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Apr 25, 2024

Problem

As a follow-up on #7467, also measure the ingestion operation speed.

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested a review from VladLazar April 25, 2024 16:04
@skyzh skyzh requested a review from a team as a code owner April 25, 2024 16:04
@skyzh skyzh enabled auto-merge (squash) April 25, 2024 16:25
@skyzh skyzh merged commit c59abed into main Apr 25, 2024
47 of 48 checks passed
@skyzh skyzh deleted the skyzh/commit-time branch April 25, 2024 16:39
Copy link

2766 tests run: 2645 passed, 0 failed, 121 skipped (full report)


Code coverage* (full report)

  • functions: 28.1% (6483 of 23057 functions)
  • lines: 46.9% (46063 of 98179 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
f023bf2 at 2024-04-25T16:46:51.675Z :recycle:

skyzh added a commit that referenced this pull request May 21, 2024
The metrics was added in #7515
to observe if #7467 introduces
any perf regressions.

The change was deployed on 5/7 and no changes are observed in the
metrics. So it's safe to remove the metrics now.

Signed-off-by: Alex Chi Z <chi@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants