Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vm-image): specify sql exporter listen port #7526

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Apr 26, 2024

Problem

Extracted from #7514, 9399 is the default port. We want to specify it b/c we will start a second sql exporter for autoscaling agent soon.

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Signed-off-by: Alex Chi Z <chi@neon.tech>
Copy link

2796 tests run: 2675 passed, 0 failed, 121 skipped (full report)


Flaky tests (2)

Postgres 16

  • test_download_remote_layers_api: debug

Postgres 14

  • test_pageserver_recovery: debug

Code coverage* (full report)

  • functions: 28.3% (6547 of 23143 functions)
  • lines: 46.9% (46226 of 98460 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
ed41f03 at 2024-04-26T18:44:08.053Z :recycle:

@skyzh skyzh merged commit 89cae64 into main Apr 29, 2024
53 checks passed
@skyzh skyzh deleted the skyzh/specify-port-sqlexporter branch April 29, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants