Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: Exclude compute and retries #7529

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

khanova
Copy link
Contributor

@khanova khanova commented Apr 28, 2024

Problem

Alerts fire if the connection the compute is slow.

Summary of changes

Exclude compute and retry from latencies.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@khanova khanova requested a review from a team as a code owner April 28, 2024 11:58
Copy link

2796 tests run: 2675 passed, 0 failed, 121 skipped (full report)


Flaky tests (1)

Postgres 15

  • test_gc_of_remote_layers: debug

Code coverage* (full report)

  • functions: 28.3% (6547 of 23143 functions)
  • lines: 47.0% (46255 of 98502 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
fc1143d at 2024-04-28T12:46:57.622Z :recycle:

@khanova khanova merged commit 24ce878 into main Apr 29, 2024
53 checks passed
@khanova khanova deleted the proxy-exclude-compute-and-retries branch April 29, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants