Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: Create disconnect events #7535

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Conversation

khanova
Copy link
Contributor

@khanova khanova commented Apr 29, 2024

Problem

It's not possible to get the duration of the session from proxy events.

Summary of changes

  • Added a separate events folder in s3, to record disconnect events.
  • Disconnect events are exactly the same as normal events, but also have disconnect_timestamp field not empty.
  • @oruen suggested to fill it with the same information as the original events to avoid potentially heavy joins.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@khanova khanova requested a review from a team as a code owner April 29, 2024 10:11
Copy link

github-actions bot commented Apr 29, 2024

2820 tests run: 2699 passed, 0 failed, 121 skipped (full report)


Flaky tests (1)

Postgres 16

  • test_vm_bit_clear_on_heap_lock: debug

Code coverage* (full report)

  • functions: 28.2% (6554 of 23272 functions)
  • lines: 46.8% (46289 of 98859 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
916a3e6 at 2024-04-29T12:53:44.887Z :recycle:

@khanova khanova merged commit 1684bbf into main Apr 29, 2024
53 checks passed
@khanova khanova deleted the proxy-create-disconnect-events branch April 29, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants