Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pageserver): concise error message for layer traversal #7565

Merged
merged 2 commits into from
May 1, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Apr 30, 2024

Problem

Instead of showing the full path of layer traversal, we now only show tenant (in tracing context)+timeline+filename.

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested a review from koivunej April 30, 2024 15:02
@skyzh skyzh requested a review from a team as a code owner April 30, 2024 15:02
Copy link

github-actions bot commented Apr 30, 2024

2856 tests run: 2735 passed, 0 failed, 121 skipped (full report)


Flaky tests (1)

Postgres 16

  • test_vm_bit_clear_on_heap_lock: debug

Code coverage* (full report)

  • functions: 28.1% (6601 of 23486 functions)
  • lines: 46.8% (46866 of 100233 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
e1a1ab7 at 2024-05-01T15:16:13.680Z :recycle:

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh enabled auto-merge (squash) May 1, 2024 14:35
@skyzh skyzh merged commit 26e6ff8 into main May 1, 2024
53 checks passed
@skyzh skyzh deleted the skyzh/debug-str branch May 1, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants