Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(pageserver): plumb through RequestContext to VirtualFile write methods #7566

Merged
merged 8 commits into from
May 2, 2024
Merged

chore(pageserver): plumb through RequestContext to VirtualFile write methods #7566

merged 8 commits into from
May 2, 2024

Conversation

problame
Copy link
Contributor

This PR introduces no functional changes.

The read path will be done separately.

refs #6107
refs #7386

@problame problame requested a review from a team as a code owner April 30, 2024 16:07
@problame problame requested review from petuhovskiy and koivunej and removed request for petuhovskiy April 30, 2024 16:07
@problame problame mentioned this pull request Apr 30, 2024
Open
@problame problame requested a review from a team as a code owner April 30, 2024 16:49
@problame problame removed the request for review from tristan957 April 30, 2024 16:50
@problame
Copy link
Contributor Author

(Sorry for the botched up merge, git town wasn't properly configured -,- )

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 30, 2024 •
edited

2856 tests run: 2736 passed, 0 failed, 120 skipped (full report)

Flaky tests (4)

Postgres 16

  • test_pageserver_init_node_id: debug

Postgres 15

  • test_vm_bit_clear_on_heap_lock: debug

Postgres 14

  • test_partial_evict_tenant[relative_spare]: release
  • test_gc_of_remote_layers: debug

Code coverage* (full report)

  • functions: 28.1% (6604 of 23539 functions)
  • lines: 46.8% (46968 of 100446 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
ad08aa9 at 2024-05-02T09:51:56.172Z :recycle:

@problame
Copy link
Contributor Author

I missed the on-demand download code path, expect more pushes.

@problame problame changed the title chore: plumb through RequestContext to VirtualFile write methods chore(pageserver): plumb through RequestContext to VirtualFile write methods Apr 30, 2024
tristan957
tristan957 approved these changes May 2, 2024
View reviewed changes
pageserver/src/tenant/config.rs Outdated Show resolved Hide resolved
@problame problame merged commit 45ec868 into main May 2, 2024
53 checks passed
@problame problame deleted the problame/plumb-through-request-context-to-virtualfile branch May 2, 2024 16:58
@problame problame mentioned this pull request May 3, 2024
Open
conradludgate pushed a commit that referenced this pull request May 8, 2024
@problame @conradludgate
chore(pageserver): plumb through RequestContext to VirtualFile write …
65c0641 
…methods (#7566)

This PR introduces no functional changes.

The read path will be done separately.

refs #6107
refs #7386
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koivunej koivunej koivunej approved these changes

@tristan957 tristan957 tristan957 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@problame @koivunej @tristan957