Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of pg_waldump --ignore option #7578

Merged
merged 4 commits into from
May 2, 2024

Conversation

lubennikovaav
Copy link
Contributor

Problem

Previously, the --ignore option was only used when reading from a single file.
With this PR pg_waldump -i is enough to open any neon WAL segments

Summary of changes

pg_waldump changes are in corresponding postgres repo PRs
neondatabase/postgres#416
neondatabase/postgres#417
neondatabase/postgres#418

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Simple test to ensure that pg_waldump works with neon WAL files
@lubennikovaav lubennikovaav requested a review from a team as a code owner May 1, 2024 19:36
@lubennikovaav lubennikovaav requested review from conradludgate and knizhnik and removed request for conradludgate May 1, 2024 19:37
Copy link

github-actions bot commented May 1, 2024

2886 tests run: 2765 passed, 0 failed, 121 skipped (full report)


Flaky tests (3)

Postgres 16

  • test_vm_bit_clear_on_heap_lock: debug

Postgres 15

  • test_vm_bit_clear_on_heap_lock: debug

Postgres 14

  • test_partial_evict_tenant[relative_spare]: release

Code coverage* (full report)

  • functions: 28.0% (6601 of 23539 functions)
  • lines: 46.7% (46863 of 100357 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
dd231dd at 2024-05-02T12:02:53.288Z :recycle:

@lubennikovaav lubennikovaav enabled auto-merge (squash) May 2, 2024 10:16
@lubennikovaav lubennikovaav merged commit 69bf1ba into main May 2, 2024
53 checks passed
@lubennikovaav lubennikovaav deleted the test_waldump_ignore_errors_1 branch May 2, 2024 11:52
conradludgate pushed a commit that referenced this pull request May 8, 2024
Previously, the --ignore option was only used when reading from a single
file.
With this PR pg_waldump -i is enough to open any neon WAL segments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants