Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageserver): compile warning of download_object.ctx on macos #7596

Merged
merged 1 commit into from
May 3, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented May 2, 2024

Problem

fix macOS compile warning introduced in 45ec868

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested a review from problame May 2, 2024 18:57
@skyzh skyzh requested a review from a team as a code owner May 2, 2024 18:57
Copy link

github-actions bot commented May 2, 2024

2862 tests run: 2741 passed, 0 failed, 121 skipped (full report)


Flaky tests (1)

Postgres 15

  • test_vm_bit_clear_on_heap_lock: debug

Code coverage* (full report)

  • functions: 28.0% (6604 of 23549 functions)
  • lines: 46.8% (46982 of 100483 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
0b9d386 at 2024-05-02T19:38:41.382Z :recycle:

Copy link
Contributor

@problame problame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yuck

@problame problame merged commit 3582a95 into main May 3, 2024
53 checks passed
@problame problame deleted the skyzh/warning-macos branch May 3, 2024 08:55
@problame
Copy link
Contributor

problame commented May 3, 2024

Merged it because I actually need the build to work on my macOS :)

conradludgate pushed a commit that referenced this pull request May 8, 2024
fix macOS compile warning introduced in
45ec868

Signed-off-by: Alex Chi Z <chi@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants