Fix test_ts_of_lsn_api flakiness #7599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2904 tests run: 2783 passed, 0 failed, 121 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
5abba19 at 2024-05-06T16:49:28.991Z :recycle: |
|
Baseline case, no patches (50 retries): one occurence. |
|
Doubling the wait time seems to have fixed it. The test now takes 30% longer but that's fine, still below 20 seconds per run. report link. |
|
Turning on synchronous commit still makes it occur (300 retries): one occurence. |
|
report after doubling the time again and enabling synchronous commit. Not a single failure. I'm not happy about this fix because it just changes parameters around, and likely the test is still going to exhibit flakiness, but it's solving the immediate problem I'd say. |
koivunej
reviewed
May 6, 2024
koivunej
approved these changes
May 6, 2024
|
For posterity, this is the link to the log that triggered the regression. |
conradludgate
pushed a commit
that referenced
this pull request
May 8, 2024
Changes parameters to fix the flakiness of `test_ts_of_lsn_api`. Already now, the amount of flakiness of the test is pretty low. With this, it's even lower. cc #5768
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes parameters to fix the flakiness of
test_ts_of_lsn_api. Already now, the amount of flakiness of the test is pretty low. With this, it's even lower.cc #5768