tests: relax test download remote layers api #7604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test triggers layer download failures on demand. It is possible to modify the failpoint during a `Timeline::get_vectored` right between the vectored read and it's validation read. This means that one of the reads can fail while the other one succeeds and vice versa. These errors are expected, so allow them to happen.
2868 tests run: 2747 passed, 0 failed, 121 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
964e17c at 2024-05-03T11:07:10.285Z :recycle: |
|
Repeated many times here. No failures. |
VladLazar
force-pushed
the
vlad/relax_test_download_remote_layers_api
branch
from
0039fad
to
964e17c
Compare
arpad-m
approved these changes
May 3, 2024
conradludgate
pushed a commit
that referenced
this pull request
May 8, 2024
## Problem This test triggers layer download failures on demand. It is possible to modify the failpoint during a `Timeline::get_vectored` right between the vectored read and it's validation read. This means that one of the reads can fail while the other one succeeds and vice versa. ## Summary of changes These errors are expected, so allow them to happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This test triggers layer download failures on demand. It is possible to modify the failpoint
during a
Timeline::get_vectoredright between the vectored read and it's validation read.This means that one of the reads can fail while the other one succeeds and vice versa.
Summary of changes
These errors are expected, so allow them to happen.
Checklist before requesting a review
Checklist before merging