refactor: move NodeMetadata to pageserver_api; use it from neon_local
#7606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arpad-m
approved these changes
May 3, 2024
jcsp
reviewed
May 3, 2024
|
Can you write a PR description please? The linked issue doesn't make it obvious why NodeMetadata would be related to compaction |
2904 tests run: 2783 passed, 0 failed, 121 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
f8ebebe at 2024-05-03T17:21:03.143Z :recycle: |
jcsp
approved these changes
May 3, 2024
conradludgate
pushed a commit
that referenced
this pull request
May 8, 2024
…local` (#7606) This is the first step towards representing all of Pageserver configuration as clean `serde::Serialize`able Rust structs in `pageserver_api`. The `neon_local` code will then use those structs instead of the crude `toml_edit` / string concatenation that it does today. refs #7555 --------- Co-authored-by: Alex Chi Z <iskyzh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step towards representing all of Pageserver configuration as clean
serde::Serializeable Rust structs inpageserver_api.The
neon_localcode will then use those structs instead of the crudetoml_edit/ string concatenation that it does today.refs #7555