Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageserver): remove update_gc_info calls in tests #7608

Merged
merged 1 commit into from
May 3, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented May 3, 2024

Problem

introduced by #7468 conflicting with #7584

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@skyzh skyzh requested a review from a team as a code owner May 3, 2024 15:22
@skyzh skyzh requested a review from problame May 3, 2024 15:22
@skyzh skyzh enabled auto-merge (squash) May 3, 2024 15:23
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh force-pushed the skyzh/fix-main-build-test branch from c5f3a50 to eb72b6e Compare May 3, 2024 15:24
@skyzh skyzh disabled auto-merge May 3, 2024 15:25
@skyzh skyzh enabled auto-merge (squash) May 3, 2024 15:25
@skyzh skyzh merged commit ef03b38 into main May 3, 2024
47 checks passed
@skyzh skyzh deleted the skyzh/fix-main-build-test branch May 3, 2024 16:01
Copy link

github-actions bot commented May 3, 2024

2880 tests run: 2759 passed, 0 failed, 121 skipped (full report)


Flaky tests (3)

Postgres 16

  • test_gc_of_remote_layers: debug

Postgres 15

  • test_tenant_delete_smoke: release

Postgres 14

  • test_partial_evict_tenant[relative_spare]: release

Code coverage* (full report)

  • functions: 31.4% (6224 of 19809 functions)
  • lines: 47.2% (46681 of 98965 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
eb72b6e at 2024-05-03T16:09:27.256Z :recycle:

conradludgate pushed a commit that referenced this pull request May 8, 2024
introduced by #7468 conflicting
with #7584

Signed-off-by: Alex Chi Z <chi@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants